Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization in CPEBase to fix UBSAN error #38400

Merged
merged 1 commit into from Jun 23, 2022
Merged

Initialization in CPEBase to fix UBSAN error #38400

merged 1 commit into from Jun 23, 2022

Conversation

OzAmram
Copy link
Contributor

@OzAmram OzAmram commented Jun 16, 2022

This PR adds an initialization for one value of the DetParam struct in PixelCPEBase that was causing a UBSAN error (#35036
). No changes in output are expected

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Jun 16, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38400/30599

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

  • RecoLocalTracker/SiPixelRecHits (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jun 16, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Jun 16, 2022

@cmsbuild , please test for CMSSW_12_5_UBSAN_X

@tvami
Copy link
Contributor

tvami commented Jun 16, 2022

type bugfix,trk

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0770a/25576/summary.html
COMMIT: 3fd1c59
CMSSW: CMSSW_12_5_UBSAN_X_2022-06-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38400/25576/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e0770a/25575/summary.html
COMMIT: 3fd1c59
CMSSW: CMSSW_12_5_X_2022-06-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38400/25575/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659074
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3659038
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar mentioned this pull request Jun 17, 2022
Open
VinInn
VinInn reviewed Jun 17, 2022
View reviewed changes
RecoLocalTracker/SiPixelRecHits/interface/PixelCPEBase.h
@@ -49,7 +49,8 @@ class PixelCPEBase : public PixelClusterParameterEstimator {
const PixelTopology* theTopol;
const RectangularPixelTopology* theRecTopol;

GeomDetType::SubDetector thePart;
//set default value of enum to avoid USBAN errors
GeomDetType::SubDetector thePart = GeomDetEnumerators::invalidDet;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why just this data member and not all the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the only enum variable and the only one causing the UBSAN error (still very strange to me as the uninitialized value is never used). I could add initialization to the other variables if we want

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok. the usual false positive...

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a54a9c7 into cms-sw:master Jun 23, 2022
@iarspider iarspider mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinInn VinInn VinInn left review comments

Assignees
No one assigned
Labels
bug-fix code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved trk
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@OzAmram @cmsbuild @tvami @clacaputo @perrotta @VinInn