Run3-sim119 Provide overlap checking cfg's for 2026 geometries: DDD and DD4hep #38401
Conversation
|
@cmsbuild Please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38401/30600
|
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97d7fe/25577/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
simulation-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -2,7 +2,7 @@ | |||
| # Way to use this: | |||
| # cmsRun g4OverlapCheck2026_cfg.py geometry=D86 tol=0.1 | |||
There was a problem hiding this comment.
Perhaps for a privately used config this update of a comment line is not necessary:
| # cmsRun g4OverlapCheck2026_cfg.py geometry=D86 tol=0.1 | |
| # cmsRun g4OverlapCheck2026DDD_cfg.py geometry=D86 tol=0.1 |
@bsunanda please let us know if you want to update it, or if you agree merging the PR as it is, instead
There was a problem hiding this comment.
@perrotta , I would guess DD4hep is our default for these checks, not DDD, but Sunanda may clarify.
There was a problem hiding this comment.
@perrotta , I would guess DD4hep is our default for these checks, not DDD, but Sunanda may clarify.
@civanch tbat's not the point. The point is that in the instruction to run it the name of the file is wrong. This is a very minor issue for a script that has to be run privately, by experts I imagine. In any case, if @bsunanda agrees we can even fix it and merge without retriggering tests and signature, as it is just a comment line
|
For phase2 I believe it is still DDD. DD4Hep have some issues which are not addressed as yet. We should try to address them soon.
________________________________
From: Andrea Perrotta ***@***.***
Sent: 17 June 2022 14:54
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-sim119 Provide overlap checking cfg's for 2026 geometries: DDD and DD4hep (PR #38401)
@perrotta commented on this pull request.
________________________________
In SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck2026DDD_cfg.py<#38401 (comment)>:
@@ -2,7 +2,7 @@
# Way to use this:
# cmsRun g4OverlapCheck2026_cfg.py geometry=D86 tol=0.1
@perrotta<https://github.com/perrotta> , I would guess DD4hep is our default for these checks, not DDD, but Sunanda may clarify.
@civanch<https://github.com/civanch> tbat's not the point. The point is that in the instruction to run it the name of the file is wrong. This is a very minor issue for a script that has to be run privately, by experts I imagine. In any case, if @bsunanda<https://github.com/bsunanda> agrees we can even fix it and merge without retriggering tests and signature, as it is just a comment line
—
Reply to this email directly, view it on GitHub<#38401 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOSQMG2V7VCUEG5IQ4DVPRYOZANCNFSM5ZA2TYCQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I shall change the name in the comment line
________________________________
From: Sunanda Banerjee
Sent: 17 June 2022 14:56
To: cms-sw/cmssw; cms-sw/cmssw
Cc: Mention
Subject: RE: [cms-sw/cmssw] Run3-sim119 Provide overlap checking cfg's for 2026 geometries: DDD and DD4hep (PR #38401)
For phase2 I believe it is still DDD. DD4Hep have some issues which are not addressed as yet. We should try to address them soon.
________________________________
From: Andrea Perrotta ***@***.***
Sent: 17 June 2022 14:54
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-sim119 Provide overlap checking cfg's for 2026 geometries: DDD and DD4hep (PR #38401)
@perrotta commented on this pull request.
________________________________
In SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck2026DDD_cfg.py<#38401 (comment)>:
@@ -2,7 +2,7 @@
# Way to use this:
# cmsRun g4OverlapCheck2026_cfg.py geometry=D86 tol=0.1
@perrotta<https://github.com/perrotta> , I would guess DD4hep is our default for these checks, not DDD, but Sunanda may clarify.
@civanch<https://github.com/civanch> tbat's not the point. The point is that in the instruction to run it the name of the file is wrong. This is a very minor issue for a script that has to be run privately, by experts I imagine. In any case, if @bsunanda<https://github.com/bsunanda> agrees we can even fix it and merge without retriggering tests and signature, as it is just a comment line
—
Reply to this email directly, view it on GitHub<#38401 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOSQMG2V7VCUEG5IQ4DVPRYOZANCNFSM5ZA2TYCQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
cmsbuild
added
code-checks-pending
pending-signatures
simulation-pending
tests-pending
and removed
tests-approved
code-checks-approved
labels
|
@cmsbuild Please test |
|
please abort |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38401/30609
|
|
merge |
cmsbuild
added
code-checks-approved
orp-approved
and removed
orp-pending
code-checks-pending
labels
|
Pull request #38401 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
PR description:
Provide overlap checking cfg's for 2026 geometries: DDD and DD4hep
PR validation:
Use the cfg's to find overlaps in the 2026D92 scenario
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special