Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Copies RawEventContent compression settings for Repack jobs #38408

Merged
merged 1 commit into from Jun 18, 2022

Conversation

germanfgv
Copy link
Contributor

PR description:

Drops RAWEventContent configuration from repack output, while keeping it compression configuration. Fix to #37791.
Following the discussion in #38025 (comment), this PR uses copy to avoid propagating changes done in Repack.py back to the RawEventContent object

PR validation:

Used RunRepack.py to generate a test configuration. The resulting PSet had the required output module attributes and the repack job was executed correctly using cmsRun. The produced RAW file included the expected products.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #38049. Needed to avoid dropping necessary products from T0 RAW files.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2022

A new Pull Request was created by @germanfgv (Germn Felipe Giraldo Villa) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@germanfgv
Copy link
Contributor Author

@perrotta After checking the code for 12_4_0 I realized I failed to provide the backport for PR #38049 . Here it is finally. I'm sorry for the delay. @qliphy can one of you trigger the tests, please?

@qliphy
Copy link
Contributor

qliphy commented Jun 17, 2022

allow @germanfgv test rights

@qliphy
Copy link
Contributor

qliphy commented Jun 17, 2022

please test

@perrotta
Copy link
Contributor

backport of #38049

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a99f25/25594/summary.html
COMMIT: 9eba22c
CMSSW: CMSSW_12_4_X_2022-06-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38408/25594/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3680335
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Intended to the 12_4_1 release for data taking

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ac23ffd into cms-sw:CMSSW_12_4_X Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants