Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] Add DiMuonVertexMonitor module and use it for ALCARECOTkAlDiMuonAndVertexDQM #38425

Merged
merged 6 commits into from Jun 27, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 20, 2022

backport of #38378 and #38463

PR description:

PR #33770 added a new ALCARECO producer (ALCARECOTkAlDiMuonAndVertex).
This PR adds the DQM monitoring for that stream and adds a new DQM Analyzer (DiMuonVertexMonitor) to monitor the properties of the selected di-muon vertices.
I profit of this PR to make a clean-up of the TkAlCaRecoMonitor module as well in commit 9371f30.

PR validation:

Run successfully a modified version of 136.887 to include the TkAlDiMuonAndVertex ALCARECO producer.

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #38378 + #38463

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • DQMOffline/Alignment (dqm)

@perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 20, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3af28b/25619/summary.html
COMMIT: 3b27170
CMSSW: CMSSW_12_4_X_2022-06-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38425/25619/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3680334
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 284.401 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 284.386 KiB AlCaReco/TkAlDiMuonAndVertex
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@emanueleusai
Copy link
Member

@mmusich is this not needed in 12_3?

@mmusich
Copy link
Contributor Author

mmusich commented Jun 21, 2022

is this not needed in 12_3?

it might be needed if we plan to reconstruct 13.6TeV data with it. It's not clear at least to me if that will be the case or not?

@emanueleusai
Copy link
Member

ok thank you for the clarification! ok we'll get there when the situation is more defined

@mmusich
Copy link
Contributor Author

mmusich commented Jun 22, 2022

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Jun 22, 2022

type new-feature

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3af28b/25689/summary.html
COMMIT: 98c118c
CMSSW: CMSSW_12_4_X_2022-06-21-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38425/25689/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3680334
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 289.962 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 289.946 KiB AlCaReco/TkAlDiMuonAndVertex
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@mmusich
Copy link
Contributor Author

mmusich commented Jun 27, 2022

urgent

  • @cms-sw/orp-l2 please consider this for 12.4.1

@tvami
Copy link
Contributor

tvami commented Jun 27, 2022

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tvami
Copy link
Contributor

tvami commented Jun 27, 2022

+alca

  • I just wanted this to be on the alca list given that it affects AlCa stuff... :D

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit cfd9784 into cms-sw:CMSSW_12_4_X Jun 27, 2022
@mmusich mmusich deleted the addDiMuonVertexMonitor_12_4_X branch June 27, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants