Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plots for 2/3 aligned ROCs per BX, backport of PR #38435 #38436

Conversation

AndreaBellora
Copy link
Contributor

PR description:

Two more Online DQM plots added for the PPS pixels. These plots are necessary for the PPS alignment run (23/06/22).
The added plots follow a similar implementation to an already existing one, just with different parameters.

PR validation:

This PR can be validated by running a DQM playback of Run 354054 (currently ongoing). No additional validation is needed, the implementation is almost identical to code that is already implemented.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of PR #38435. The backport is necessary because this update needs to be deployed in the P5 Online DQM for the PPS alignment run (23/06/22).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2022

A new Pull Request was created by @AndreaBellora for CMSSW_12_3_X.

It involves the following packages:

  • DQM/CTPPS (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@AndreaBellora AndreaBellora marked this pull request as ready for review June 20, 2022 11:18
@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14a3c8/25668/summary.html
COMMIT: cea61d7
CMSSW: CMSSW_12_3_X_2022-06-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38436/25668/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3630290
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3630260
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

tested at P5 + ready to be deployed tomorrow

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #38435

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants