Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update online GTs with new AlCaRecoTriggerBits tag and offline GTs with EGM regression #38555

Merged

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Jun 29, 2022

PR description:

This is to update the HLT, Express and Prompt GTs with new AlCaRecoTriggerBits tags that include a key for a new AlCaReco introduced in #38254.
We also take the chance to update the Express and Prompt GTs to be inline with the ones already use for data-taking operations. They contain the PPS tag PPSOpticalFunctions_express_v9 for the express GGT and PPSOpticalFunctions_prompt_v9 for the Prompt one.

In addition, we include new offline data GTs with a new snapshot time to take into account a new payload appended recently for EGM regression, announced in https://cms-talk.web.cern.ch/t/offline-gt-updating-egm-electron-sc-regression-tags-for-eta-extended-region-incorporating-122x-ideal-ic-samples/12187

The differences wrt to the previous GTs are listed below:
run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_frozen_v3/124X_dataRun3_HLT_frozen_v4

run3_hlt_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_relval_v5/124X_dataRun3_HLT_relval_v6

run3_data_express
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_Express_frozen_v1/124X_dataRun3_Express_frozen_v2

run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_Prompt_frozen_v1/124X_dataRun3_Prompt_frozen_v2

run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_v4/124X_dataRun3_v5

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_relval_v4/124X_dataRun3_relval_v5

PR validation:

runTheMatrix.py -l 136.897,139.001,138.5,138.4 --ibeos -j16

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport but will be backported to 123X and 124X.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38555/30793

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @malbouis for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @Martin-Grunewald, @missirol, @mmusich, @ChrisMisan, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

@malbouis please also add in the description that the express and prompt GTs also include the new PPSOpticalFunctions tags!

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38555/30795

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38555 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@malbouis malbouis force-pushed the alca_updateDataGTs_triggerBits_EGM-125X branch from 47c5aa3 to 6d389c1 Compare June 29, 2022 16:24
@malbouis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b0aea/25889/summary.html
COMMIT: 6d389c1
CMSSW: CMSSW_12_5_X_2022-06-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38555/25889/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654586
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3654556
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 30, 2022

+alca

  • test pass, no diffs are seen as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6686652 into cms-sw:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants