Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[124X (backport)] Fix PR #38450 (backport of #38437) to disable mkFit in pixelLessStep: backport of PR #38565 #38566

Merged
merged 2 commits into from Jun 30, 2022

Conversation

mmasciov
Copy link
Contributor

PR description:

This PR offers a fix to PR #38450 (backport of #38437), that disables mkFit for pixelLessStep, so that the new era is fully recognized.

This is a backport of PR #38565

PR validation:

Standard MTV for SoftQCD (PU=0) sample:
http://uaf-10.t2.ucsd.edu/~mmasciov/MIC/SoftQCD/MTV_SoftQCD_PRFix/

Denominator (blue): default Run3 era
cmsDriver.py step3 --conditions auto:phase1_2022_realistic -s RAW2DIGI,RECO:reconstruction_trackingOnly,VALIDATION:@trackingOnlyValidation,DQM:@trackingOnlyDQM --datatier DQMIO -n 5000 --geometry DB:Extended --era Run3 --eventcontent DQM --no_exec --filein file:/data2/mmasciov/SoftQCD/CMSSW_12_4_0_pre4/src/step2.root --fileout step3_SoftQCD_default.root --python_filename step3_SoftQCD_default.py --nThreads 8

Numerator (red): Run3_ckfPixelLessSttep era
cmsDrivery.py step3 --conditions auto:phase1_2022_realistic -s RAW2DIGI,RECO:reconstruction_trackingOnly,VALIDATION:@trackingOnlyValidation,DQM:@trackingOnlyDQM --datatier DQMIO -n 5000 --geometry DB:Extended --era Run3_ckfPixelLessStep --eventcontent DQM --no_exec --filein file:/data2/mmasciov/SoftQCD/CMSSW_12_4_0_pre4/src/step2.root --fileout step3_SoftQCD_ckfPixelLess.root --python_filename step3_SoftQCD_ckfPixelLess.py --nThreads 8

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #38566 was updated. @perrotta, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jun 30, 2022

test parameters:

  • workflows = 11634.71,11634.72

@mmusich
Copy link
Contributor

mmusich commented Jun 30, 2022

please test

@jordan-martins
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c28592/25915/summary.html
COMMIT: 5fd55af
CMSSW: CMSSW_12_4_X_2022-06-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38566/25915/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c28592/11634.71_TTbar_14TeV+2021_trackingRun3CkfPixelLessStep+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c28592/11634.72_TTbar_14TeV+2021_trackingOnlyRun3CkfPixelLessStep+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675663
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3675633
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ad0e425 into cms-sw:CMSSW_12_4_X Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants