Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx319 Take care of the dd4hep issue - 2 separate xml files, one for G4 and one for fireworks #38638

Merged
merged 2 commits into from Jul 9, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 7, 2022

PR description:

Take care of the dd4hep issue - 2 separate xml files, one for G4 and one for fireworks. The dd4hep constructor for "Tubs" takes startPhi, endPhi while the interpreter for cmsShow uses startPhi, deltaPhi. This is taken care of in this PR and all xml files in the full scenario description take care of startPhi, endPhi sequence. There is no overlap in phase2 scenarios done using dd4hep (as in ddd).

PR validation:

Ran the dump as well as SIM step usingdd4hep to test this

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38638/30924

  • This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@bsunanda bsunanda changed the title Phase2-hgx310 Take care of the dd4hep issue - 2 separate xml files, one for G4 and one for fireworks Phase2-hgx319 Take care of the dd4hep issue - 2 separate xml files, one for G4 and one for fireworks Jul 7, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38638/30925

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @beaucero, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 7, 2022

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db21fd/26062/summary.html
COMMIT: 3a772e6
CMSSW: CMSSW_12_5_X_2022-07-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38638/26062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654771
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3654741
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 8, 2022

+1

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 9, 2022

@srimanob Please approve this PR

@srimanob
Copy link
Contributor

srimanob commented Jul 9, 2022

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jul 9, 2022

+1

@cmsbuild cmsbuild merged commit 8914280 into cms-sw:master Jul 9, 2022
@cvuosalo
Copy link
Contributor

@bsunanda I don't think the Fireworks solution is the right one. The Tube constructor has this signature:

dd4hep::Tube(rmin, rmax, dz, startPhi, endPhi);

It is not correct to pass a deltaPhi value for the last parameter, as this code is doing in the Fireworks case.
I think the problem resides in the code that creates the geometry file for Fireworks. It is that code that should translate between endPhi and deltaPhi for Fireworks, not the algorithm.

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 16, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants