Run3 GEMGeometryBuilder Run3 modifier #38666

hyunyong · 2022-07-09T10:07:26Z

GEM Run3 modifier setup for the alignment.

PR description:

Update the GEM geometry builder to use alignment tags.
Need to backport to 12_4_X

GEM doesn't have ideal geometry cff for digi.
Do we need to add ideal geometry cff and update configurations?
Some configurations use GEM default geometry builder as ideal geometry but they don't use the Run3 modifier, so it looks fine but I need to get a confirmation.

tvami · 2022-07-09T10:12:41Z

@hyunyong please make it clear in the PR description that you want this in 12_4_X...

tvami · 2022-07-09T10:13:30Z

type gem,new-feature

cmsbuild · 2022-07-09T10:14:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38666/30956

This PR adds an extra 12KB to repository

cmsbuild · 2022-07-09T10:15:04Z

A new Pull Request was created by @hyunyong for master.

It involves the following packages:

Geometry/GEMGeometryBuilder (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @watson-ij, @fabiocos, @jshlee, @bsunanda, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-07-09T10:44:39Z

@cmsbuild Please test

tvami · 2022-07-09T10:48:40Z

This will fail w/o a new GT

cmsbuild · 2022-07-09T11:57:44Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-385255/26099/summary.html
COMMIT: 5dc8aef
CMSSW: CMSSW_12_5_X_2022-07-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38666/26099/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

138.4

----- Begin Fatal Exception 09-Jul-2022 13:02:30 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 346512
   [1] Prefetching for module GEMEfficiencyAnalyzer/'gemEfficiencyAnalyzerSta'
   [2] Calling method for EventSetup module GEMGeometryESModule/''
   [3] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

138.5

----- Begin Fatal Exception 09-Jul-2022 13:04:40 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 346512
   [1] Prefetching for module GEMEfficiencyAnalyzer/'gemEfficiencyAnalyzerSta'
   [2] Calling method for EventSetup module GEMGeometryESModule/''
   [3] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

139.001

----- Begin Fatal Exception 09-Jul-2022 13:05:13 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMRecHitProducer/'hltGemRecHits'
   [1] Calling method for EventSetup module GEMGeometryESModule/''
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

136.897136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3/step2_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3.log
136.899136.899_RunCosmics2021CRAFT+RunCosmics2021CRAFT+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3/step2_RunCosmics2021CRAFT+RunCosmics2021CRAFT+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3.log
138.1138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 09-Jul-2022 13:04:55 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMDigiProducer/'simMuonGEMDigis'
   [1] Calling method for EventSetup module GEMGeometryESModule/''
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 09-Jul-2022 13:11:44 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMRecHitProducer/'hltGemRecHits'
   [1] Calling method for EventSetup module GEMGeometryESModule/''
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 09-Jul-2022 13:05:01 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMDigiProducer/'simMuonGEMDigis'
   [1] Calling method for EventSetup module GEMGeometryESModule/''
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

tvami · 2022-07-10T11:47:39Z

Geometry/GEMGeometryBuilder/python/gemGeometryDB_cfi.py

+
+from Configuration.Eras.Modifier_run3_GEM_cff import run3_GEM
+
+run3_GEM.toModify(GEMGeometryESModule, applyAlignment = True)


Done we also need

phase2_GEM.toModify(GEMGeometryESModule, applyAlignment = True)

as well?

phase2 GEM has GE2/1 and GE0, so it needs a different geometry tag.

After private discussion offline between PR author and @cms-sw/alca-l2 it was decided to postpone the update of phase2 to a later moment.

francescobrivio · 2022-07-11T21:45:04Z

test parameters:

pull_request = Add GEM alignment in all Run3 GTs and update BeamSpot in Run3 MC GTs #38692

francescobrivio · 2022-07-11T21:45:52Z

@cmsbuild please test

cmsbuild · 2022-08-09T07:40:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

tvami · 2022-08-09T12:13:47Z

urgent

I understand this needs to be used in 12_4_X

qliphy · 2022-08-11T01:04:13Z

please test
to refresh

cmsbuild · 2022-08-11T05:52:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-385255/26749/summary.html
COMMIT: 7154328
CMSSW: CMSSW_12_5_X_2022-08-10-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38666/26749/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3692476
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3692438
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

qliphy · 2022-08-11T13:28:33Z

@hyunyong Just to confirm that the differences shown in wf 138.5 is expected or not?:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_5_X_2022-08-10-2300+385255/52071/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/GEM_RecHits.html

qliphy · 2022-08-12T15:27:49Z

@hyunyong Just to confirm that the differences shown in wf 138.5 is expected or not?: https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_5_X_2022-08-10-2300+385255/52071/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/GEM_RecHits.html

@jshlee @watson-ij

qliphy · 2022-08-15T00:58:57Z

please test

cmsbuild · 2022-08-15T05:26:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-385255/26808/summary.html
COMMIT: 7154328
CMSSW: CMSSW_12_5_X_2022-08-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38666/26808/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3692476
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3692438
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

qliphy · 2022-08-15T06:04:45Z

@hyunyong @jshlee @watson-ij @quark2 the differences shown in wf 138.5 is expected or not?:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_5_X_2022-08-14-2300+385255/52125/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/GEM.html

quark2 · 2022-08-19T07:27:23Z

Hi @qliphy,

Sorry for my late reply. I've reproduced the compared plots, some of which are the follows:

The changes are slightly different, which should be due to the alignment. All other 3 plots have similar slight shifts. Note that this PR is for the alignment, and these plots are from real data (the wf 138.5.)

Best regards,
Byeonghak Ko

qliphy · 2022-08-19T14:42:46Z

please test
to check again

cmsbuild · 2022-08-19T19:57:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-385255/26935/summary.html
COMMIT: 7154328
CMSSW: CMSSW_12_5_X_2022-08-19-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38666/26935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3693040
DQMHistoTests: Total failures: 22
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3692996
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

qliphy · 2022-08-20T01:19:05Z

+1

hyunyong added 2 commits July 9, 2022 10:52

Run3 GEMGeometryBuilder alignment modifier

502aabe

Run3 GEMGeometryBuilder alignment modifier

5dc8aef

cmsbuild added this to the CMSSW_12_5_X milestone Jul 9, 2022

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jul 9, 2022

cmsbuild added gem new-feature labels Jul 9, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 9, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 9, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 9, 2022

tvami reviewed Jul 10, 2022

View reviewed changes

francescobrivio mentioned this pull request Jul 11, 2022

Add GEM alignment in all Run3 GTs and update BeamSpot in Run3 MC GTs #38692

Merged

cmsbuild added the requires-external label Jul 11, 2022

cmsbuild removed the tests-rejected label Jul 11, 2022

cmsbuild added the geometry-approved label Aug 9, 2022

cmsbuild added the urgent label Aug 9, 2022

cmsbuild added tests-started and removed tests-approved labels Aug 11, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 11, 2022

cmsbuild added tests-started and removed tests-approved labels Aug 15, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 15, 2022

cmsbuild added tests-started and removed tests-approved labels Aug 19, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 19, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 20, 2022

cmsbuild merged commit 6aa1bf3 into cms-sw:master Aug 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3 GEMGeometryBuilder Run3 modifier #38666

Run3 GEMGeometryBuilder Run3 modifier #38666

hyunyong commented Jul 9, 2022 •

edited

tvami commented Jul 9, 2022

tvami commented Jul 9, 2022

cmsbuild commented Jul 9, 2022

cmsbuild commented Jul 9, 2022

bsunanda commented Jul 9, 2022

tvami commented Jul 9, 2022

cmsbuild commented Jul 9, 2022

tvami Jul 10, 2022

hyunyong Jul 10, 2022

francescobrivio Jul 11, 2022

francescobrivio commented Jul 11, 2022

francescobrivio commented Jul 11, 2022

cmsbuild commented Aug 9, 2022

tvami commented Aug 9, 2022

qliphy commented Aug 11, 2022

cmsbuild commented Aug 11, 2022

qliphy commented Aug 11, 2022

qliphy commented Aug 12, 2022

qliphy commented Aug 15, 2022

cmsbuild commented Aug 15, 2022

qliphy commented Aug 15, 2022 •

edited

quark2 commented Aug 19, 2022

qliphy commented Aug 19, 2022

cmsbuild commented Aug 19, 2022

qliphy commented Aug 20, 2022


		from Configuration.Eras.Modifier_run3_GEM_cff import run3_GEM

		run3_GEM.toModify(GEMGeometryESModule, applyAlignment = True)

Run3 GEMGeometryBuilder Run3 modifier #38666

Run3 GEMGeometryBuilder Run3 modifier #38666

Conversation

hyunyong commented Jul 9, 2022 • edited

PR description:

tvami commented Jul 9, 2022

tvami commented Jul 9, 2022

cmsbuild commented Jul 9, 2022

cmsbuild commented Jul 9, 2022

bsunanda commented Jul 9, 2022

tvami commented Jul 9, 2022

cmsbuild commented Jul 9, 2022

RelVals

RelVals-INPUT

AddOn Tests

tvami Jul 10, 2022

Choose a reason for hiding this comment

hyunyong Jul 10, 2022

Choose a reason for hiding this comment

francescobrivio Jul 11, 2022

Choose a reason for hiding this comment

francescobrivio commented Jul 11, 2022

francescobrivio commented Jul 11, 2022

cmsbuild commented Aug 9, 2022

tvami commented Aug 9, 2022

qliphy commented Aug 11, 2022

cmsbuild commented Aug 11, 2022

Comparison Summary

qliphy commented Aug 11, 2022

qliphy commented Aug 12, 2022

qliphy commented Aug 15, 2022

cmsbuild commented Aug 15, 2022

Comparison Summary

qliphy commented Aug 15, 2022 • edited

quark2 commented Aug 19, 2022

qliphy commented Aug 19, 2022

cmsbuild commented Aug 19, 2022

Comparison Summary

qliphy commented Aug 20, 2022

hyunyong commented Jul 9, 2022 •

edited

qliphy commented Aug 15, 2022 •

edited