Use a safer syntax in Geometry/ForwardCommonData

[perrotta]

PR description:

Solves #38604

It migrates to a safer syntax (no explicit types for the cloned parameters) the following two files

• Geometry/ForwardCommonData/python/hfnoseParametersInitialization_cfi.py
• Geometry/ForwardCommonData/python/hfnoseV15ParametersInitialization_cfi.py

While doing so I also fixed two conceptual mistakes (attempt to modify a module in a different configuration):

• Geometry/HGCalCommonData/python/hgcalParametersInitialization_cfi.py

This wasn't needed anyhow, because the same modifier was already (correctly) applied to the cloned module

For the same reason I removed the customization from

• Geometry/ForwardCommonData/python/hfnoseParametersInitialization_cfi.py

as it should more safely rely on the one already present in the cloned module instead

Attn @bsunanda

PR validation:

It builds succesfully
No changes expected whatsoever

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38672/30964

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• Geometry/ForwardCommonData (geometry)
• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @bsunanda, @beaucero, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5c159/26107/summary.html
COMMIT: b9aeab7
CMSSW: CMSSW_12_5_X_2022-07-10-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38672/26107/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3655970
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3655940
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[srimanob]

Should safer syntax be applied to HGCAl,
https://github.com/cms-sw/cmssw/blob/master/Geometry/HGCalCommonData/python/hgcalEEParametersInitialization_cfi.py
also ?

[srimanob]

@cmsbuild please test workflow 39434.911

Just to make sure that Phase-2 DD4hep runs after this clean up.

[perrotta]

Should safer syntax be applied to HGCAl, https://github.com/cms-sw/cmssw/blob/master/Geometry/HGCalCommonData/python/hgcalEEParametersInitialization_cfi.py also ?

The file you are pointing at is the one from which all other config are cloned. I don't think there is anything safer for it, unless we decide to clone it further from somewhere else, which is beyond the scope of this fix

[srimanob]

Hi @perrotta
OK, understand. Thanks.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5c159/26117/summary.html
COMMIT: b9aeab7
CMSSW: CMSSW_12_5_X_2022-07-10-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38672/26117/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3759188
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3759158
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 45 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

Technical PR. Existing phase-2 DD4hep workflow, 39434.911_TTbar_14TeV+2026D88, runs fine.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1