Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Run3 ALCA Express/Prompt workflow #38681

Merged
merged 2 commits into from Jul 21, 2022

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Jul 11, 2022

PR description:

Add one Express-like and one Prompt-like ALCA workflows covering ALCRECO, ALCAPROMPT to Harvestor using Run-3 data.

2022A SingleMu data is used for Express like workflow(2022B SingleMu data seems have problem accessing through xrootd)

2022B ZeroBias data is used for Prompt like (MinimumBias data has zero events in 2022B Collision runs so far, so use ZeroBias instead)

PR validation:

The two workflows are tested by runTheMatrix

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport

@tvami
Copy link
Contributor

tvami commented Jul 11, 2022

thanks @tocheng I think it would be useful to backport this to 12_4_X too, the pp data taking is happening with that, so the wf-s being tested here would make sense there

@tvami
Copy link
Contributor

tvami commented Jul 11, 2022

assign alca

@tvami
Copy link
Contributor

tvami commented Jul 11, 2022

type new-feature

@tvami
Copy link
Contributor

tvami commented Jul 11, 2022

test parameters:

  • workflows = 1001.3,1002.3

@tvami
Copy link
Contributor

tvami commented Jul 11, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38681/30969

  • This PR adds an extra 52KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @jordan-martins, @bbilin, @AdrianoDee, @srimanob, @kskovpen, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@@ -12,6 +12,8 @@
workflows[1000] = [ '',['RunMinBias2011A','TIER0','SKIMD','HARVESTDfst2','ALCASPLIT']]
workflows[1001] = [ '',['RunMinBias2011A','TIER0EXP','ALCAEXP','ALCAHARVDSIPIXELCALRUN1','ALCAHARVD1','ALCAHARVD2','ALCAHARVD3','ALCAHARVD4','ALCAHARVD5','ALCAHARVD7','ALCAHARVD8']]
workflows[1001.2] = [ '',['RunZeroBias2017F','TIER0EXPRUN2','ALCAEXPRUN2','ALCAHARVDSIPIXELCAL','ALCAHARVDSIPIXELCALLA','ALCAHARVD4','ALCAHARVDSIPIXELALIHG']]
workflows[1001.3] = [ '',['RunSingleMuon2022A','TIER0EXPRUN3','ALCAEXPRUN3','ALCAHARVDEXPRUN3']]
workflows[1002.3] = [ '',['RunZeroBias2022B','TIER0PROMPTRUN3','ALCAEXPRUN3','ALCAHARVDEXPRUN3']]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the "Prompt" configuration re-running the ALCAEXPRUN3 block? Shouldn't it rather run the run-3 equivalent of ALCASPLIT ?

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-228118/26124/summary.html
COMMIT: 1ec5b2a
CMSSW: CMSSW_12_5_X_2022-07-10-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38681/26124/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.858136.858_RunNoBPTX2018A+RunNoBPTX2018A+HLTDR2_2018+RECODR2_2018reHLTAlCaTkCosmics_Offline+HARVEST2018/step2_RunNoBPTX2018A+RunNoBPTX2018A+HLTDR2_2018+RECODR2_2018reHLTAlCaTkCosmics_Offline+HARVEST2018.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-228118/1001.3_RunSingleMuon2022A+RunSingleMuon2022A+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-228118/1002.3_RunZeroBias2022B+RunZeroBias2022B+TIER0PROMPTRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3655970
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3655939
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.43 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 138.5 ): 0.215 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 138.5 ): 0.215 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

ChrisMisan commented Jul 11, 2022

file opening error in 136.858

@ChrisMisan
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38681/31146

@cmsbuild
Copy link
Contributor

Pull request #38681 was updated. @malbouis, @yuanchao, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Jul 20, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-228118/26333/summary.html
COMMIT: 96482c8
CMSSW: CMSSW_12_5_X_2022-07-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38681/26333/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-228118/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-228118/1002.3_RunZeroBias2022B+RunZeroBias2022B+TIER0PROMPTRUN3+ALCASPLITRUN3+ALCAHARVDEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3662417
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3662386
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.398 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 138.5 ): 0.199 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 138.5 ): 0.199 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 20, 2022

+alca

@tvami
Copy link
Contributor

tvami commented Jul 20, 2022

@srimanob @kskovpen please resign, thanks!

@srimanob
Copy link
Contributor

+Upgrade

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet