Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GT for DQM clients unitTests and input file used for unitTest #38712

Merged
merged 1 commit into from Jul 14, 2022

Conversation

francescobrivio
Copy link
Contributor

PR description:

With the activation of the GEMAlignment in #38666 and the update of the GTs in #38692, some DQM unitTests were failing due to the fact that they were still using the auto:run2_data GT, this PR updates them to auto:run3_data (even the ones were the GT is actually commented out, but I guess it is useful to have it updated when running privately).

I profit of the same PR to update the file used in the DQM unitTest from a 2021 cosmics run, to an ExpressPhysics FEVT 2022 collision run at 13.6 TeV which seems more appropriate for testing the clients in Run 3.

PR validation:

scram b runtests runs fine including the new GTs and the activation of the GEMAlignment

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but a 12_4_X backport will be provided

@francescobrivio
Copy link
Contributor Author

test parameters:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38712/31011

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-869767/26178/summary.html
COMMIT: 6f4d31b
CMSSW: CMSSW_12_5_X_2022-07-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38712/26178/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-gem_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 19726 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3653734
  • DQMHistoTests: Total failures: 56765
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3596941
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.254 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.250 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 7 / 49 workflows

@mmusich
Copy link
Contributor

mmusich commented Jul 13, 2022

@francescobrivio

this PR can also work standalone, and this set of commands runs fine:

cmsrel CMSSW_12_5_X_2022-07-12-2300/
cd CMSSW_12_5_X_2022-07-12-2300/src/
cmsenv
git cms-merge-topic 38712
scramv1 b -j 20
cd DQM/Integration/python/clients/
voms-proxy-init -voms cms
cmsRun gem_dqm_sourceclient-live_cfg.py unitTest=True

would it make sense to decouple it from the update of the GEM alignment and let it go in, independently?

@francescobrivio
Copy link
Contributor Author

would it make sense to decouple it from the update of the GEM alignment and let it go in, independently?

Yes I agree, let's go independently so it can be integrated in the IBs

@francescobrivio
Copy link
Contributor Author

test parameters:
*

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-869767/26190/summary.html
COMMIT: 6f4d31b
CMSSW: CMSSW_12_5_X_2022-07-12-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38712/26190/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3653966
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3653942
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 14, 2022

+1

@cmsbuild cmsbuild merged commit 49f8463 into cms-sw:master Jul 14, 2022
@francescobrivio francescobrivio deleted the alca-updateDQMrun3 branch July 19, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants