update unit tests for G4e refitter package

[mmusich]

PR description:

Since there are widespread plans of using the G4e refitting technology for both the muon momentum scale calibration for the W mass analysis and for the global tracker alignment procedure, it's important that we start testing it.
#38864 fixed the issues that prevented the correct testing of the package and introduced a simple analyzer for track extrapolation checks. This PR adds the consumes to the existing test analyzer and adds both of them to the unit tests of this package.

PR validation:

Relies on the add unit tests, that have been successfully exercised with scram b runtests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cc:
@bendavid

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38738/31052

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• TrackPropagation/Geant4e (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@felicepantaleo, @JanFSchulte, @VinInn, @lecriste, @mmusich, @mtosi, @ebrondol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38738/31056

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #38738 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d754ac/26249/summary.html
COMMIT: 3a4e678
CMSSW: CMSSW_12_5_X_2022-07-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38738/26249/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testG4Refitter had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3653966
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3653942
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

The G4 refitter unit test itself is implemented in #38864

I noticed you took my commit and place it there. That's fine. What I am after is just fixing the technical stuff:

cmssw/TrackPropagation/Geant4e/test/Geant4ePropagatorAnalyzer.cc

Line 336 in ec1a3b9

iEvent.getByLabel<SimTrackContainer>(G4TrkSrc_, simTracks);

as promised I'll have a look this week and I can recycle this branch.

[civanch]

2m limit is arbitrary. In CMS we do not have 2m empty space in central detector.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38738/31533

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #38738 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d754ac/26787/summary.html
COMMIT: dd89eb8
CMSSW: CMSSW_12_5_X_2022-08-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38738/26787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692476
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3692446
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1