Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Add CSCCluster skim config #38808

Merged
merged 5 commits into from Jul 22, 2022
Merged

Conversation

kakwok
Copy link
Contributor

@kakwok kakwok commented Jul 21, 2022

PR description:

This is a backport of #37782
This PR adds the config for a RAW-AOD skim for the CSC clusters events, based on new LLP trigger paths.
The CSC cluster skim saves the following collections in addition to standard RAW-AOD output:

csc2DRecHits
dt1DRecHits

The CSC cluster skim selects events passing the following HLT paths, which is already included in the HLT v2 menu:

HLT_CscCluster_Loose_v*
HLT_CscCluster_Medium_v*
HLT_CscCluster_Tight_v*
HLT_L1CSCShower_DTCluster50_v2
HLT_L1CSCShower_DTCluster75_v2

HLT Jira ticket

PR validation:

same as #37782

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #37782

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2022

A new Pull Request was created by @kakwok for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

urgent

  • should go into 12_4_4

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

backport of #37782

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

@cmsbuild , please test

  • tho I think nothing tests this...

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdd79a/26378/summary.html
COMMIT: c0a4dba
CMSSW: CMSSW_12_4_X_2022-07-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38808/26378/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676156
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 22, 2022

+1

@cmsbuild cmsbuild merged commit 30449f3 into cms-sw:CMSSW_12_4_X Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants