GEM Timing Plots #38818

nickh2000 · 2022-07-21T14:59:20Z

PR description:

This PR creates two GEM timing plots:

gemVFATBXPerChamber - plots hits by VFAT and BX, each plot indexed by different chambers and layers

gemChamberVFATBX - plots hits by VFAT and Chamber, each plot indexed by different BX's (-3 to 3)

PR validation:

Validated with runTheMatrix.py -l limited -i all --ibeos.

…ged 1-2 rather than 0-1

cmsbuild · 2022-07-21T15:06:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31192

This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31192/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31192/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

nickh2000 · 2022-07-25T08:08:59Z

I fixed the code. Will this label have it reevaluated?

code-checks-pending

…ged 1-2 rather than 0-1

cmsbuild · 2022-07-25T11:13:23Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31251

This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31251/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31251/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-07-25T11:31:46Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31255

This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31255/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31255/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-07-25T11:47:52Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31258

This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31258/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38818/31258/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-07-25T12:02:24Z

A new Pull Request was created by @nickh2000 for master.

It involves the following packages:

DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

emanueleusai · 2022-07-28T03:03:38Z

please test

emanueleusai · 2022-07-28T03:04:24Z

type gem

emanueleusai · 2022-07-28T03:04:33Z

type feature

cmsbuild · 2022-07-28T06:58:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45f387/26497/summary.html
COMMIT: 0c6d9b9
CMSSW: CMSSW_12_5_X_2022-07-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38818/26497/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3667670
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3667646
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 4046.679999999999 KiB( 50 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 202.334 KiB L1T/L1TStage2EMTF
Checked 210 log files, 47 edm output root files, 51 DQM output files
TriggerResults: no differences found

emanueleusai · 2022-08-02T06:08:30Z

+1

cmsbuild · 2022-08-02T06:08:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-08-02T06:37:26Z

+1

qliphy

@nickh2000 Please have a check and fix on the issue #38940

qliphy · 2022-08-03T07:25:14Z

DQM/L1TMonitor/src/L1TStage2EMTF.cc

+        //Added plots 07-21-22 ***
+        gemVFATBXPerChamber[chamber - 1][hist_index][layer]->Fill(Hit->BX(), vfat);
+        //indexed plots by BX 07-21-22
+        gemChamberVFATBX[hist_index][Hit->BX() + 3]->Fill(chamber_bin(1, 1, chamber), vfat);


It seems "Hit->BX() + 3" can be as large as "7" and exceeds the boundary, which then cause the issue as reported in #38940

eyigitba · 2022-08-03T08:10:43Z

Hi @qliphy , this is very strange indeed. EMTF DAQ readout window is [-3,+3] which should never return 7 for this. Maybe this protection should be added to the EMTF unpacker rather than the DQM plots.

eyigitba · 2022-08-03T09:29:28Z

ok, I found the problem. During LS2 there were some issues with corrupted GEM TPs which apparently sometimes extend to invalid BX values (4 in this case). I'll add a protection to the unpacker about this soon. This should fix this crash as well

Added gemChamberBXVFAT and gemBXVFATPerChamber plots; Made layers ran…

b60cd8c

…ged 1-2 rather than 0-1

cmsbuild added this to the CMSSW_12_5_X milestone Jul 21, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 21, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 21, 2022

nickh2000 force-pushed the from-CMSSW_12_5_0_pre3 branch from 57a5282 to 51ce54c Compare July 25, 2022 08:02

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 25, 2022

nickh2000 force-pushed the from-CMSSW_12_5_0_pre3 branch from 72ef39f to 96ab713 Compare July 25, 2022 11:05

Added gemChamberBXVFAT and gemBXVFATPerChamber plots; Made layers ran…

5f71c8a

…ged 1-2 rather than 0-1

nickh2000 force-pushed the from-CMSSW_12_5_0_pre3 branch from 96ab713 to 5f71c8a Compare July 25, 2022 11:07

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jul 25, 2022

code checks

1a8d691

nickh2000 force-pushed the from-CMSSW_12_5_0_pre3 branch from c91f555 to 1a8d691 Compare July 25, 2022 11:42

cmsbuild added tests-started and removed tests-pending labels Jul 28, 2022

cmsbuild added the gem label Jul 28, 2022

cmsbuild added the new-feature label Jul 28, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 28, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Aug 2, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 2, 2022

cmsbuild merged commit 7f0cfad into cms-sw:master Aug 2, 2022

cmsbuild mentioned this pull request Aug 2, 2022

Update run for DQM beamhlt client unitTest #38925

Merged

qliphy mentioned this pull request Aug 2, 2022

Segfault in L1TStage2EMTF #38940

Closed

cmsbuild mentioned this pull request Aug 3, 2022

[ROOT626] Root update v6 26 00 patches cms-sw/cmsdist#8010

Merged

qliphy reviewed Aug 3, 2022

View reviewed changes

eyigitba mentioned this pull request Aug 3, 2022

Added protection against out-of-range BX values in EMTF unpacker blocks #38961

Merged

eyigitba mentioned this pull request Sep 16, 2022

[12_4_X] Added protection against out-of-range BX values in EMTF unpacker blocks #39413

Merged

mmusich mentioned this pull request Nov 1, 2022

gemChamberVFATBX0GENeg11 with duplicate labels makes T0 crash on 12_5 reply #39936

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GEM Timing Plots #38818

GEM Timing Plots #38818

nickh2000 commented Jul 21, 2022

cmsbuild commented Jul 21, 2022

nickh2000 commented Jul 25, 2022 •

edited

cmsbuild commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

emanueleusai commented Jul 28, 2022

emanueleusai commented Jul 28, 2022

emanueleusai commented Jul 28, 2022

cmsbuild commented Jul 28, 2022

emanueleusai commented Aug 2, 2022

cmsbuild commented Aug 2, 2022

qliphy commented Aug 2, 2022

qliphy left a comment

qliphy Aug 3, 2022

eyigitba commented Aug 3, 2022 •

edited

eyigitba commented Aug 3, 2022

Navigation Menu

GEM Timing Plots #38818

GEM Timing Plots #38818

Conversation

nickh2000 commented Jul 21, 2022

PR description:

PR validation:

cmsbuild commented Jul 21, 2022

nickh2000 commented Jul 25, 2022 • edited

cmsbuild commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

emanueleusai commented Jul 28, 2022

emanueleusai commented Jul 28, 2022

emanueleusai commented Jul 28, 2022

cmsbuild commented Jul 28, 2022

Comparison Summary

emanueleusai commented Aug 2, 2022

cmsbuild commented Aug 2, 2022

qliphy commented Aug 2, 2022

qliphy left a comment

Choose a reason for hiding this comment

qliphy Aug 3, 2022

Choose a reason for hiding this comment

eyigitba commented Aug 3, 2022 • edited

eyigitba commented Aug 3, 2022

nickh2000 commented Jul 25, 2022 •

edited

eyigitba commented Aug 3, 2022 •

edited