Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and log cleanup in EventFilter/Utilities #3883

Merged
merged 7 commits into from May 15, 2014

Conversation

smorovic
Copy link
Contributor

Hi,
this pull requests fixes these issues:

  • process termination via SIGINT/SIGTERM. Previously some threads did not catch this and process would be left hanging. Event counting consistency check (exception thrown) is turned off for signal interruption.
  • added file size to the output json for cross-checks in the output data merging stages
  • removal / rate reduction of log messages from EvF components and more uniform formatting (for the new log output parser in EvF)
  • removing changes in json library that were introduced for debugging, but I forgot to remove them.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_1_X.

Bugfixes and log cleanup in EventFilter/Utilities

It involves the following packages:

EventFilter/Utilities

@mommsen, @cmsbuild, @Degano, @emeschi, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented May 15, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3883/1539/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented May 15, 2014

DAS query issue. @nclopezo, can you make sure we run tests using the
text based DAS cache?

@cmsbuild
Copy link
Contributor

ktf added a commit that referenced this pull request May 15, 2014
Bugfixes and log cleanup in EventFilter/Utilities
@ktf ktf merged commit 9d18e7f into cms-sw:CMSSW_7_1_X May 15, 2014
@cmsbuild
Copy link
Contributor

@nclopezo
Copy link
Contributor

@ktf I added the option to the pull request test script. I am using this file https://raw.githubusercontent.com/cms-sw/cmsdist/IB/CMSSW_7_1_X/stable/das-cache.file

@ktf
Copy link
Contributor

ktf commented May 16, 2014

Thanks.

@smorovic smorovic deleted the bugfixes branch October 7, 2014 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants