Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace_Geometry_cff with GeometryDB_cff in TrackingTools #38955

Merged
merged 1 commit into from Aug 9, 2022

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Aug 2, 2022

PR description:
Review on the Reco part of #31113

process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")

In this PR, TrackingTools configuration files (4 files) are fixed.

        modified:   TrackingTools/TrackAssociator/test/TestTrackAssociator.py
        modified:   TrackingTools/TrackRefitter/test/CosmicTrajectoryReader_cfg.py
        modified:   TrackingTools/TrackRefitter/test/TrackReader_cfg.py
        modified:   TrackingTools/TrackRefitter/test/TrajectoryReader_cfg.py

PR validation:

Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38955/31401

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

  • TrackingTools/TrackAssociator (reconstruction)
  • TrackingTools/TrackRefitter (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@jhgoh, @trocino, @Fedespring, @VourMa, @HuguesBrun, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bellan, @sscruz, @ebrondol, @CeliaFernandez, @lecriste, @gpetruc, @mmusich, @mtosi, @dgulhan, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@clacaputo
Copy link
Contributor

Dear @cms-sw/tracking-pog-l2 , the cfg files targetted by this PR haven't been updated for a while (not considering technical PRs), i.e. they are using as input quite old root files. Do you think we can remove them? Thanks

@mmusich
Copy link
Contributor

mmusich commented Aug 3, 2022

Do you think we can remove them? Thanks

Prefer to keep them. Eventually can become unit tests

@clacaputo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f83729/26640/summary.html
COMMIT: 334c93c
CMSSW: CMSSW_12_5_X_2022-08-03-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38955/26640/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691510
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3691486
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

+reconstruction

  • technical PR
  • no reco changes

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 9, 2022

+1

@cmsbuild cmsbuild merged commit 99299af into cms-sw:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants