Improve the handling of module labels unsafe for DQM

[fwyzard]

Follow up to #38963.

Replace the unsafe characters in-place to avoid make unnecessary copies of the labels.

Use the safe label for the name of the DQM histograms, but keep the original label for their titles.

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38966/31420

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• HLTrigger/Timer (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[gartung]

enable profiling

[gartung]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0070ac/26643/summary.html
COMMIT: aad8b57
CMSSW: CMSSW_12_5_X_2022-08-04-1100/el8_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38966/26643/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @eyigitba Added protection against out-of-range BX values in EMTF unpacker blocks #38961
• @gartung HLTrigger/Timer: add function FastTimerService::fix_for_dqm which replaces check for illegal dqm characters for path so it can be used on paths and labels. #38963

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0070ac/26643/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0070ac/26643/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3691510
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3691486
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[missirol]

Just for my education: where can one check the performance change of FastTimerService in the Profiling tests (or elsewhere)?

[gartung]

The pull request test results appears under the IB release they were tested against. For instance
https://cmssdt.cern.ch/circles/web/piechart.php?local=false&dataset=CMSSW_12_5_X_2022-08-03-1100%2Fel8_amd64_gcc10%2F39634.21%2FPR-d69cf0%2F26629%2Fstep3_RAW2DIGI_L1Reco_RECO_RECOSIM_PU.resources&resource=time_thread&colours=default&groups=reco_PhaseII&threshold=0

[gartung]

You click on the See Logs link next to "Profiling wf 11834.21 Results" and the select the json file like the one below.
https://cmssdt.cern.ch/circles/web/piechart.php?local=false&dataset=CMSSW_12_5_X_2022-08-04-1100/el8_amd64_gcc10/11834.21/PR-0070ac/26643/step4_PAT_PU.resources&resource=time_thread&colours=default&groups=reco_PhaseII&threshold=0

[gartung]

The files seems to be missing even though the logs indicate that the job ran without throwing any exceptions.

[gartung]

It may take a file for the web server to register that the files are present. I can see them when I log directly into the web server host.

[missirol]

Thanks for the info, @gartung !

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1