Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch pixelLess iteration to use CKF instead of mkFit #38967

Merged
merged 2 commits into from Aug 16, 2022

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Aug 4, 2022

Discussion in PPD Aug 4
https://indico.cern.ch/event/1187803/#43-discussion-of-reversion-to
appears to be converging to the decision to switch the pixelLess iteration to use CKF instead of mkFit.

This PR makes the switch and removes Run3_ckfPixelLessStep, which is now identical to Run3
(I checked this using the run3 wf 11834.0 expanded config for step3).

@cms-sw/tracking-pog-l2

@@ -16,5 +15,4 @@
trackingMkFitHighPtTripletStep,
trackingMkFitDetachedQuadStep,
trackingMkFitDetachedTripletStep,
trackingMkFitPixelLessStep,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we comment it, hoping to put it back ~ soon?

Copy link
Contributor Author

@slava77 slava77 Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, commented out parts are usually not advised by reco: if some change is expected in the code soon, the usual advice is to make an issue in github

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38967/31421

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @lecriste, @trtomei, @mmusich, @mtosi, @beaucero, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Aug 4, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/26642/summary.html
COMMIT: dda3f63
CMSSW: CMSSW_12_5_X_2022-08-04-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38967/26642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 19186 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691510
  • DQMHistoTests: Total failures: 30994
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3660492
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 138.5 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 3 / 50 workflows

@srimanob
Copy link
Contributor

@cmsbuild please test

@srimanob
Copy link
Contributor

@slava77
I have not followed up closely. I assume this PR is ready to go, right? I just call the test again as the last one is a week ago.

@slava77
Copy link
Contributor Author

slava77 commented Aug 12, 2022

@slava77 I have not followed up closely. I assume this PR is ready to go, right? I just call the test again as the last one is a week ago.

I do not expect any functional modifications in this PR.

The only pending item was a formal go-ahead from PPD/Validation that this is good to go for the default.
But that part is perhaps on the ORP part of the sign off.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/26780/summary.html
COMMIT: dda3f63
CMSSW: CMSSW_12_5_X_2022-08-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38967/26780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 19335 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 30990
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3661463
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 138.5 ): 0.004 KiB JetMET/SUSYDQM
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 3 / 50 workflows

@srimanob
Copy link
Contributor

+Upgrade

From the upgrade side, this PR follows the agreement on switching pixelless iteration to use CKF instead of mkFit.

@kskovpen
Copy link
Contributor

+pdmv

@perrotta
Copy link
Contributor

+1

  • As agreed at the Aug 16 ORP meeting

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@slava77
Copy link
Contributor Author

slava77 commented Nov 30, 2023

type tracking

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370908/36218/summary.html
COMMIT: dda3f63
CMSSW: CMSSW_14_0_X_2023-11-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38967/36218/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants