New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete deprecated scripts accessing geometry with prior-run2 GT in Calibration/Hcal #39014
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39014/31476 |
A new Pull Request was created by @yuanchao (Yuan CHAO) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@yuanchao please squash the commits |
@bsunanda please have a look at this PR, and if you disagree with the cleaning, please provide new configs that work, and possibly make them into unit tests, thanks! |
type hcal |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39014/31484
|
Pull request #39014 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again. |
These are indeed obsolete scripts and can be deleted |
thanks @bsunanda ! |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-deba04/26737/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following up the migration of Geometry_cff to GeometryDB_cff (#35278), proper GlobalTag needs to be set in advance. We take the chance to clean up AlCa/DB related scripts that accessing with prior-run2 GT in Calibration/HcalAlCaRecoProducers and Calibration/HcalCalibAlgos.
PR validation:
Delete deprecated script that can't be tested with modern geometry.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a back port and no back port expected.