Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated scripts accessing geometry with prior-run2 GT in Calibration/Hcal #39014

Merged
merged 1 commit into from Aug 11, 2022

Conversation

yuanchao
Copy link
Contributor

@yuanchao yuanchao commented Aug 9, 2022

PR description:

Following up the migration of Geometry_cff to GeometryDB_cff (#35278), proper GlobalTag needs to be set in advance. We take the chance to clean up AlCa/DB related scripts that accessing with prior-run2 GT in Calibration/HcalAlCaRecoProducers and Calibration/HcalCalibAlgos.

PR validation:

Delete deprecated script that can't be tested with modern geometry.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a back port and no back port expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39014/31476

  • This PR adds an extra 16KB to repository

  • Found files with invalid states:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2022

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

  • Calibration/HcalAlCaRecoProducers (alca)
  • Calibration/HcalCalibAlgos (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Aug 9, 2022

@yuanchao please squash the commits

@tvami
Copy link
Contributor

tvami commented Aug 9, 2022

@bsunanda please have a look at this PR, and if you disagree with the cleaning, please provide new configs that work, and possibly make them into unit tests, thanks!

@tvami
Copy link
Contributor

tvami commented Aug 9, 2022

type hcal

@cmsbuild cmsbuild added the hcal label Aug 9, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39014/31484

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39014 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@bsunanda
Copy link
Contributor

These are indeed obsolete scripts and can be deleted

@tvami
Copy link
Contributor

tvami commented Aug 10, 2022

thanks @bsunanda !

@tvami
Copy link
Contributor

tvami commented Aug 10, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-deba04/26737/summary.html
COMMIT: 6724bcb
CMSSW: CMSSW_12_5_X_2022-08-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39014/26737/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3692440
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 10, 2022

+alca

  • agreed by HCAL as well

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 11, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants