New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining plots for PPSTimingCalibration for Payload Inspector #39024
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39024/31489
|
A new Pull Request was created by @Kszemka (Aleksandra Krzemińska) for master. It involves the following packages:
@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f67f9/26742/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+db |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The main aim of this PR is to add remaining plots for PPSTimingCalibration class to Payload Inspector software so to be able to visualize it on the website.
PR validation:
The code was tested by a script testPPSTimingCalibration.sh (which is mostly based on getPayloadData.py from CondCore/Utilities) just to check whether the code is properly added to PI software and generate some proper data in JSON files produced by PI.
In case of testing - testPPSTimingCalibration.sh script should be run with 'run' argument.
####PR backport:
No backport.