Add run3 PCL pps alignment relval

[ChrisMisan]

PR description:

This PR adds run3 relval for PCL pps alignment calibration.

PR validation:

relval 1045

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to 12_4 will follow.

[ChrisMisan]

type new-feature, ctpps

[ChrisMisan]

test parameters:

• workflows=1045

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39059/31561

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update PU for Run3 wfs #39041, Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6007c1/26820/summary.html
COMMIT: 62db2ce
CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39059/26820/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-6007c1/1045.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSALIGRUN3+ALCAHARVDPPSALIGRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692476
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3692452
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

@cms-sw/upgrade-l2 do you have any comments about this?

[srimanob]

+Upgrade

New workflow 1045 runs fine.

Questions: I look on the log file of workflow 1045, and see the following message sometimes:

%MSG-e CTPPSPixelDataFormatter:   CTPPSPixelRawToDigi:ctppsPixelDigisAlCaRecoProducer 15-Aug-2022 14:25:23 CEST  Run: 355207 Event: 106498
 unphysical col and/or row  nllink=12 nroc=2 adc=0 col=8 row=80
%MSG

Is it known issue, normal?

[bbilin]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+Upgrade

New workflow 1045 runs fine.

Questions: I look on the log file of workflow 1045, and see the following message sometimes:

%MSG-e CTPPSPixelDataFormatter:   CTPPSPixelRawToDigi:ctppsPixelDigisAlCaRecoProducer 15-Aug-2022 14:25:23 CEST  Run: 355207 Event: 106498
 unphysical col and/or row  nllink=12 nroc=2 adc=0 col=8 row=80
%MSG

Is it known issue, normal?

@ChrisMisan @cms-sw/ctpps-dpg-l2 : could someone investigate and answer this question, before we merge this PR and it gets forgotten?

[ChrisMisan]

@perrotta Question was relayed to the PPS experts but I don't have any conclusive answer at this moment. I'll try to follow up on this possible issue on Monday.

[tvami]

@perrotta I agree that it should be followed up. On the other hand this PR is just what revels the problem, it's not caused by it or will be fixed in it, so I'd suggest to merge this and possibly make an issue out of the msg (although given that the PPS experts know about it, that might even be unnecessary )

[perrotta]

+1

• Opened issue Unphysical col and/or row reported by CTPPSPixelDataFormatter: #39124 to keep track of the resolution of the issue reported in Add run3 PCL pps alignment relval #39059 (comment)