New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PyBind11 interpreter management into its own sentry class #39157
Conversation
The use of a separate class will guarantee that the interpreter will be shut down properly even if the PyBind11ProcessDesc constructor would throw an exception.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39157/31738
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@cmsbuild, please test for CMSSW_12_5_LTO_X |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a52e3a/27026/summary.html Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a52e3a/27027/summary.html Comparison SummarySummary:
|
@Dr15Jones Do you agree? |
I agree |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The use of a separate class will guarantee that the interpreter will be shut down properly even if the
PyBind11ProcessDesc
constructor would throw an exception. Resolves #39147.PR validation:
Framework unit tests pass in the LTO build.