Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Updates on DQMOffline/ZCounting #39168

Merged
merged 2 commits into from Aug 31, 2022

Conversation

davidwalter2
Copy link
Contributor

@davidwalter2 davidwalter2 commented Aug 24, 2022

PR description:

The plugin from DQMOffline/ZCounting is currently not working due to issues with the last filter of trigger path. This PR fixes this problem. Additional updates on the functionality are done.

  • new implementation of trigger tools using HLTConfigProvider to automatically find last filter of trigger path. This way the filter name has not explicitly specified.
  • removing era modifier as they are not needed for current run 3 data taking.
  • moving z counting to electrons into a separate plugin. This way the z counting to muons is concise. The plugin for electrons does not function yet but is planned to be updated in the future.

PR validation:

cmsDriver.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of PR39119.

david walter added 2 commits August 24, 2022 10:34
-new implementation of trigger tools using HLTConfigProvider to automatically find last filter of trigger path. This way the filter name has not explicitly specified.
-removing era modifier as they are not needed for current run 3 data taking.
-moving z counting to electrons into a separate plugin. This way the z counting to muons is concise. The plugin for electrons does not function yet but is planned to be updated in the future.
-Re organization of histograms according to LUM-21-001, reducing the total amount of histograms and reducing redundant information.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2022

A new Pull Request was created by @davidwalter2 for CMSSW_12_4_X.

It involves the following packages:

  • DQMOffline/Lumi (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85a573/27071/summary.html
COMMIT: f457c02
CMSSW: CMSSW_12_4_X_2022-08-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39168/27071/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 250202.1250202.1_TTbar_13+TTbar_13INPUT+PREMIXUP15_PU25+DIGIPRMXLOCALUP15_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13INPUT+PREMIXUP15_PU25+DIGIPRMXLOCALUP15_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677206
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@davidwalter2
Copy link
Contributor Author

Can we test again?

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85a573/27112/summary.html
COMMIT: f457c02
CMSSW: CMSSW_12_4_X_2022-08-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39168/27112/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677280
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677244
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #39119

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f78b58f into cms-sw:CMSSW_12_4_X Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants