Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to GeneralHLTOffline #3919

Merged
merged 2 commits into from Jun 3, 2014

Conversation

puigh
Copy link
Contributor

@puigh puigh commented May 19, 2014

In agreement with TSG, we have made several updates to GeneralHLTOffline.

Removed:

  • All eta, phi, and eta vs phi plots.

Current set of plots produced:

  • One rate plot for all HLT paths in main folder;
  • For each dataset, one rate plot of HLT paths of that dataset;
  • For each path, one rate plot of the HLT filters of that path.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @puigh for CMSSW_7_1_X.

Updates to GeneralHLTOffline

It involves the following packages:

DQMOffline/Trigger

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3919/1563/summary.html

@cmsbuild
Copy link
Contributor

Pull request #3919 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3919/1571/summary.html

@puigh
Copy link
Contributor Author

puigh commented May 19, 2014

The errors in both of these tasks were the same:
Exception: There are not files in input from the file list

This is an error at step1 and not a result of code in this PR (I believe). How would you like me to proceed? Both of these tasks ran fine for me when using runTheMatrix locally.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented May 21, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 3, 2014
@davidlange6 davidlange6 merged commit 84e5a0f into cms-sw:CMSSW_7_1_X Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants