Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for DeepDoubleX [12_4_X] #39200

Merged
merged 3 commits into from Sep 7, 2022

Conversation

kpedro88
Copy link
Contributor

backport of #39184

attn: @mariadalfonso

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2022

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_12_4_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction)
  • RecoBTag/FeatureTools (reconstruction)

@jpata, @cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @ahinzmann, @schoef, @emilbols, @jdamgov, @JyothsnaKomaragiri, @nhanvtran, @gpetruc, @azotz, @hqucms, @hatakeyamak, @mbluj, @gkasieczka, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1ee86/27097/summary.html
COMMIT: fb46098
CMSSW: CMSSW_12_4_X_2022-08-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39200/27097/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677218
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 6, 2022

@kpedro88 would you mind submitting also a 12_5_X backport, to ensure continuity between the release cycles?

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 7, 2022

Sure, I didn't realize the milestone was changed before #39184 was merged.

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

+1

@cmsbuild cmsbuild merged commit 6631217 into cms-sw:CMSSW_12_4_X Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants