Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Declare production of Track collection after TrackExtra collection in modules run at HLT #39211

Merged
merged 1 commit into from Aug 29, 2022

Conversation

missirol
Copy link
Contributor

backport of #39201

PR description:

Verbatim backport of #39201 by @makortel.

From the description of #39201:

This PR proposes to declare the production of Track collection after TrackExtra and TrackingRecHit collections to work around a rare scheduling bug in the framework that might have caused three failures in the HLT that were reporter in #39064 (see #39064 (comment) for the details). The problem should be specific modules run in scheduled mode (i.e. modules are in Path or Sequence). Given that in all offline workflows the reconstruction code is run unscheduled, I limited to modules that I saw were in HLT_GRun_cff. I might have missed some, but I hope these changes would reduce the rate of the failures.

PR validation:

None

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#39201

Potentially relevant to current HLT online operations, see #39064.

This change works around a rare scheduling bug in the framework when
these modules are run as scheduled, see
cms-sw#39064
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X.

It involves the following packages:

  • RecoMuon/L2MuonProducer (hlt, reconstruction)
  • RecoMuon/L3MuonProducer (hlt, reconstruction)
  • RecoPixelVertexing/PixelTrackFitting (reconstruction)
  • RecoTracker/FinalTrackSelectors (reconstruction)
  • RecoTracker/TrackProducer (reconstruction)

@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @jpata, @mandrenguyen can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @abbiendi, @CeliaFernandez, @mmusich, @cericeci, @silviodonato, @JanFSchulte, @jhgoh, @sscruz, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @ebrondol, @mtosi, @dgulhan, @HuguesBrun, @Fedespring, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9620d/27119/summary.html
COMMIT: 0dab1eb
CMSSW: CMSSW_12_4_X_2022-08-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39211/27119/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677280
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677250
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@jpata
Copy link
Contributor

jpata commented Aug 26, 2022

+reconstruction

  • technical backport (bugfix for HLT)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor

Thanks @missirol for preparing the backport!

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 89b6ca3 into cms-sw:CMSSW_12_4_X Aug 29, 2022
@missirol missirol deleted the trackExtra_124X branch September 8, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants