Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] Add Tracker Alignment di-muon monitoring to other resonances #39332

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 7, 2022

backport of #39295

PR description:

This PR extends on the concept introduced at #39166 (and then followed up at #39248) in order to monitor the vertexing and mass biases for other di-muon resonances (J/ψ→µµ and Υ(1S) →µµ) used in the tracker alignment procedure.

PR validation:

Relies on the existing (and augmented) unit tests.
The output of it has been uploaded to a test GUI for convenience of inspection and it's available by connecting to:

 ssh -NL 8060:localhost:8060 <USER>@lxplus724.cern.ch

and visiting:

Morevor the single bin fits for the resonance masses are available here

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39295

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • DQMOffline/Alignment (dqm)
  • DQMOffline/Configuration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 7, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9a491/27399/summary.html
COMMIT: 4fc6e85
CMSSW: CMSSW_12_4_X_2022-09-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39332/27399/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677279
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3677254
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 133.617 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 66.880 KiB AlCaReco/TkAlUpsilonMuMu
  • DQMHistoSizes: changed ( 1000.0 ): 66.710 KiB AlCaReco/TkAlJpsiMuMu
  • DQMHistoSizes: changed ( 1000.0 ): 0.016 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.016 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB AlCaReco/TkAlDiMuonAndVertex
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 7, 2022

please test

  • no clear reason why this PR would imply the relval inputs timeout

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9a491/27407/summary.html
COMMIT: 4fc6e85
CMSSW: CMSSW_12_4_X_2022-09-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39332/27407/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677279
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3677254
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 133.617 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 66.880 KiB AlCaReco/TkAlUpsilonMuMu
  • DQMHistoSizes: changed ( 1000.0 ): 66.710 KiB AlCaReco/TkAlJpsiMuMu
  • DQMHistoSizes: changed ( 1000.0 ): 0.016 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.016 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB AlCaReco/TkAlDiMuonAndVertex
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2022

+1

@cmsbuild cmsbuild merged commit 5857ae8 into cms-sw:CMSSW_12_4_X Sep 8, 2022
@mmusich mmusich deleted the addDiMuonMonitoringToAthorResonances_12_4_X branch September 8, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants