Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support XOR operator in triggerExpression::Parser [12_5_X] #39378

Merged
merged 1 commit into from Sep 14, 2022

Conversation

missirol
Copy link
Contributor

backport of #39377

PR description:

This PR adds supports for the logical operator XOR in the triggerExpression::Parser class used by HLT (used most notably in the TriggerResultsFilter plugin).

The XOR evaluator was actually implemented already (class: OperatorXor); it's just that the Parser was not aware of it.

Unit tests are updated accordingly.

Except for unit tests, this new functionality remains for now unused in any central workflow.

Merely technical. No changes expected.

PR validation:

Improved unit tests pass.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#39377

Development of HLT menus for 2022 data-taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • HLTrigger/HLTcore (hlt)
  • HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08069a/27494/summary.html
COMMIT: e6243a5
CMSSW: CMSSW_12_5_X_2022-09-12-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39378/27494/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695824
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695800
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 82403d5 into cms-sw:CMSSW_12_5_X Sep 14, 2022
@missirol missirol deleted the devel_hltParseXOR_125X branch September 14, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants