New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PPS DMD tag, remove deprecated SiStrip DMD tag #39380
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39380/32084
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7019a7/27497/summary.html Comparison SummarySummary:
|
+alca
|
+db |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As requested in this CMSTalk post, we update the DropBoxMetadata for PPS PCL:
CTPPSRPAlignment_byPCL_v0_prompt
-->CTPPSRPAlignment_byPCL_v1_prompt
CTPPPSTimingCalibration_SAMPIC_byPCL_v0_prompt
-->CTPPPSTimingCalibration_SAMPIC_byPCL_v1_prompt
I also profit of this PR for two further updates of the DMD scripts:
SiStripApvGainRcdAfterAbortGap
key which is deprecated in favor ofSiStripApvGainAAG
as described in Remove SiStripApvGainRcdAfterAbortGap from DMD cms-AlCaDB/AlCaTools#77CondFormats/Common/test/DropBoxMetadataReader.py
PR validation:
Code runs and creates the correct payload.
PayloadInspector link: https://cern.ch/go/f6pG
This payload will be appended to the Express tag
Backport:
Not a backport, but a 12_5_X backport will be opened soon.
A 12_4_X backport might be nice, but not strictly necessay - under discussion.