Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GsfElectronCoreBaseProducer a stream module #3939

Merged

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer and helgrind report that all classes that inherit
from GsfElectronCoreBaseProducer are safe to be stream modules.

This is needed to avoid stalling in threaded RECO jobs.

The static analyzer and helgrind report that all classes that inherit
from GsfElectronCoreBaseProducer are safe to be stream modules.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Make GsfElectronCoreBaseProducer a stream module

It involves the following packages:

RecoEgamma/EgammaElectronProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3939/1592/summary.html

@Dr15Jones
Copy link
Contributor Author

failure was from DAS. @nclopezo please rerun tests.

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3939/1594/summary.html

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

The failures are from DAS. @nclopezo please rerun the tests.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 21, 2014

@nclopezo David, it looks like the comparisons script is misbehaving again.

@slava77
Copy link
Contributor

slava77 commented May 21, 2014

+1

for #3939 8a7dcba
~ trivial for non-threaded mode, jenkins runs ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 21, 2014
…erStreamModule

Multithreading -- Make GsfElectronCoreBaseProducer a stream module
@ktf ktf merged commit 3ce923e into cms-sw:CMSSW_7_1_X May 21, 2014
@nclopezo
Copy link
Contributor

@slava77

Hi Slava,
Thanks for making me notice, it seems that it was a glitch this time.

@cmsbuild
Copy link
Contributor

@Dr15Jones Dr15Jones deleted the makeGsfElectronCoreBaseProducerStreamModule branch June 12, 2014 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants