Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NVProfilerService and ProcessCallGraph [12.4.x] #39399

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 15, 2022

PR description:

Implement a couple of fixes for the ProcessCallGraph:

  • check that the Source module is added exactly once to the ProcessCallGraph;
  • avoid static variables, that would result in invalid process ids when multiple
    ProcessCallGraph instances are used e.g. by different Services.

Fix the NVProfilerService to for the case where the number of modules in the current process is not a valid indicator of the highest module id, for example if some modules have been destroyed because they cannot be part of any schedule. Instead, use a ProcessCallGraph to get the highest possible module id.

PR validation:

With these changes, adding the NVProfilerService to complex configurations (e.g. a full HLT menu) works, instead of failing with an assertion.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39398 to 12.4.x for data taking.

Using a static local variable results in invalid ids when multiple
ProcessCallGraph instances are used e.g. by different Services.
Use a ProcessCallGraph to get the highest possible module id, instead of
relaying on the modules count.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 15, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X.

It involves the following packages:

  • HLTrigger/Timer (hlt)
  • HeterogeneousCore/CUDAServices (heterogeneous)

@cmsbuild, @missirol, @Martin-Grunewald, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato, @rovere, @makortel this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 15, 2022

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 15, 2022

backport #39398

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 15, 2022

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 15, 2022

+heterogeneous

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e137bc/27573/summary.html
COMMIT: 496330b
CMSSW: CMSSW_12_4_X_2022-09-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39399/27573/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677396
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677372
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Sep 16, 2022
@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 02e27c0 into cms-sw:CMSSW_12_4_X Sep 17, 2022
@fwyzard fwyzard deleted the Fix_ProcessCallGraph_and_NVProfilerService_12_4_x branch October 29, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants