Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L1T] Phase-2, include missing collections in outputs #39401

Merged
merged 7 commits into from Oct 4, 2022

Conversation

cecilecaillol
Copy link
Contributor

PR description:

This PR addresses the missing Tk object collections in the CMSSW_12_5_0_pre5 RelVals. It includes fixes were needed to avoid errors after adding in the objects to the EventContent. One error that came up in the FEVTDEBUGHLToutput_step was: The class "l1t::TkJetWord" is compiled and for its data member "tkJetWord_" we do not have a dictionary for the collection "bitset<70>". Because of this, we will not be able to read or write this data member.
classes_def.xml was adjusted to avoid the error. Local PR: cms-l1t-offline#1048

This PR also adds missing collections for Phase 2 tau-jet-met to the event content. Specifically the 9x9 Sums for histogrammed jets, the NN Puppi taus, and the HPS taus. Local PR: cms-l1t-offline#1047

We need this PR to be backported to 12_5 for our Phase-2 L1 MC production

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39401/32105

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39401/32107

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

  • DataFormats/L1Trigger (l1)
  • L1Trigger/Configuration (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@kreczko, @rovere, @eyigitba, @Martin-Grunewald, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39401/32109

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39401 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39401/32361

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

Pull request #39401 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again.

@cecilecaillol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcf915/27926/summary.html
COMMIT: 3c4146e
CMSSW: CMSSW_12_6_X_2022-10-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39401/27926/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bcf915/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3432625
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor Author

+l1

@cecilecaillol
Copy link
Contributor Author

@cmsbuild please test

Retrigger the test as it was almost 2 weeks ago. @cecilecaillol could you please provide information as asked by @missirol in #39401 (comment)

Addressed in last commit

@srimanob
Copy link
Contributor

srimanob commented Oct 3, 2022

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 4, 2022

+1

@cmsbuild cmsbuild merged commit 0d421b5 into cms-sw:master Oct 4, 2022
@perrotta
Copy link
Contributor

perrotta commented Oct 4, 2022

@cecilecaillol @BenjaminRS please add to the PR description for reference an estimate of the increase of the event size, as I already asked for the backport PR in #39451 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants