[12.5.X] do not drop pixel duplicates for phase-2 IT reconstruction

[mmusich]

PR description:

Poor man solution to #39007.
PR #37559 has created a serious deterioration of the phase-2 track reconstruction (see https://cms-talk.web.cern.ch/t/new-validation-campaign-12-5-0-pre5-phase2-d88-added/14722/15), likely due to pixels being killed in the middle of the cluster when a PU simHit comes to overlap with a signal simHit.
This PR introduces a DropDuplicates parameters in PixelThresholdClusterizer.cc and turns that off for all phase-2 reconstruction.
Same mechanism was introduced (only for the heterogeneous version of the reconstruction) at #38761, that would have to be rebased if this PR is merged.

PR validation:

cmssw compiles, see tests at the master version of this PR: #39407 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #39407, needed for 12_5_0 in light of dedicated Phase-2 production to happen there.

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @missirol, @dkotlins, @ferencek, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from do not drop pixel duplicates for phase-2 IT reconstruction #39407

[mmusich]

@cmsbuild, please test

[tvami]

urgent

• "needed for 12_5_0 in light of dedicated Phase-2 production to happen there."

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4c72c/27646/summary.html
COMMIT: 5c6490c
CMSSW: CMSSW_12_5_X_2022-09-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39443/27646/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2224 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3699454
• DQMHistoTests: Total failures: 45625
• DQMHistoTests: Total nulls: 14
• DQMHistoTests: Total successes: 3653793
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

• backport of do not drop pixel duplicates for phase-2 IT reconstruction #39407
• code changes are consistent with the original PR
• reco changes as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #39407

[perrotta]

+1