PPS lhcInfo split: LHCInfoPerLS and LHCInfoPerFill records

[JanChyczynski]

PR description:

Definition of the new records, LHCInfoPerLS and LHCInfoPerFill, to be used instead of LHCInfo (to save space in the database by migrating members with different granularity to separate classes).

LHCInfoPerLS contains, among others, betaStarX/Y and crossingAngleX/Y (these fields were separated for X and Y) used mainly in PPS proton reconstruction . LHCInfoPerFill is a refactored clone of LHCInfo with lumiSection, betaStar and crossingAngle removed.

LHCInfoVectorizedFields is a base class for LHCInfoPerLS and LHCInfoPerFill handling fields, with values stored in vectors for expandability purposes.

PR validation:

Validation by scripts creating objects of the new classes, writing to a local sqlite database, retrieving and displaying them on stdout by the print method:

cd CondTools/RunInfo/test
cmsRun LHCInfoPerLSWriter_cfg.py 
cmsRun LHCInfoPerFillWriter_cfg.py 
cmsRun LHCInfoPerLSAnalyzer_cfg.py 
cmsRun LHCInfoPerFillAnalyzer_cfg.py 

Additionally serialization unit tests were added to testSerializationRunInfo.cpp.

The new clases were also used in further development (Populator of Conditions, update of proton reconstruction; to be submitted in next PRs) which confirmed no problems with the definitions of the records.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39495/32244

• This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39495/32244/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39495/32244/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

@JanChyczynski, CMSSW_12_6_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39495/32245

• This PR adds an extra 60KB to repository

[cmsbuild]

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for master.

It involves the following packages:

• CondCore/RunInfoPlugins (db)
• CondCore/Utilities (db)
• CondFormats/DataRecord (db, alca)
• CondFormats/RunInfo (db, alca)
• CondTools/RunInfo (db)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

type ctpps, performance-improvement

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39495/32307

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #39495 was updated. @malbouis, @yuanchao, @saumyaphor4252, @ggovi, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84ff24/27843/summary.html
COMMIT: 7b03ed3
CMSSW: CMSSW_12_6_X_2022-09-28-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39495/27843/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-84ff24/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3433154
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3433129
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

+alca

• differences only in msgLogger
• unit test passes

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• About the code non compiling if you remove the (non used) ESHandler header include, I think that it is due to a few analyzers that does not include that header even if ESHandle's are uded in them. At some point one should move the include where it is actually needed, and not rely on some other included file that (uselessly) countains it