Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMS deprecation warnings in EgammaAnalysis/ElectronTools #39501

Merged
merged 1 commit into from Sep 27, 2022
Merged

Fix CMS deprecation warnings in EgammaAnalysis/ElectronTools #39501

merged 1 commit into from Sep 27, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • switch to one modules
  • delcare shared resources
  • added esConsumes as needed

PR validation:

Code compiles without CMS warnings.

@Dr15Jones
Fix CMS deprecation warnings in EgammaAnalysis/ElectronTools
1ea0da4 
- switch to one modules
- delcare shared resources
- added esConsumes as needed
@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Sep 26, 2022
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39501/32254

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • EgammaAnalysis/ElectronTools (analysis)

can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @sobhatta, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90e5e3/27777/summary.html
COMMIT: 1ea0da4
CMSSW: CMSSW_12_6_X_2022-09-26-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39501/27777/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3624368
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3624344
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 787c75b into cms-sw:master Sep 27, 2022
@Dr15Jones Dr15Jones deleted the deprecatedEgammaAnalysisElectronTools branch October 6, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending code-checks-approved orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @perrotta