Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed misnamed files in EcalTPG unittest script #39503

Merged
merged 1 commit into from Sep 27, 2022

Conversation

perrotta
Copy link
Contributor

backport of #39235

This PR fixes the issue #38964 created in CondTools/Ecal unittests by the merged PR #38856. The issue was still present in 12_5_X, but the fix was only submitted for the master, 12_6_X (as noticed by @makortel in #39485 (comment))

Two different unit tests were writing on the same local sqlite file, causing troubles. The output files are now unique.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 26, 2022

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_12_5_X.

It involves the following packages:

  • CondTools/Ecal (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @mmusich, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor Author

@valsdav

@valsdav
Copy link
Contributor

valsdav commented Sep 26, 2022

Thanks a lot @perrotta for creating the backport!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81f01/27778/summary.html
COMMIT: 4142cad
CMSSW: CMSSW_12_5_X_2022-09-26-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39503/27778/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3699418
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Sep 27, 2022

+db

  • unit test passes

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit 203328e into cms-sw:CMSSW_12_5_X Sep 27, 2022
@perrotta perrotta deleted the backport39235 branch September 27, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants