Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Add calibration fit plot to the PPS HPTDC PCL #39506

Merged

Conversation

ChrisMisan
Copy link
Contributor

PR description:

Additional per-channel plot was added to the harvester, it allows to investigate produced calibration fit. Plot is saved together with all of the worker plots after the harvesting stage.

PR validation:

wfs 1041, 1044

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #39493

@ChrisMisan
Copy link
Contributor Author

type ctpps

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2022

A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_4_X.

It involves the following packages:

  • CalibPPS/TimingCalibration (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@ChrisMisan
Copy link
Contributor Author

backport of #39493

@ChrisMisan
Copy link
Contributor Author

test parameters:

  • workflows=1041,1044

@ChrisMisan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f24a8/27786/summary.html
COMMIT: da776d3
CMSSW: CMSSW_12_4_X_2022-09-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39506/27786/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f24a8/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f24a8/1044.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSCALRUN3+ALCAHARVDPPSCALRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3677978
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677954
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 50.939 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 1044.0 ): 50.939 KiB AlCaReco/PPSTimingCalibrationPCL
  • Checked 216 log files, 45 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Sep 27, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0827fd6 into cms-sw:CMSSW_12_4_X Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants