Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] MillePedeDQMModule: add string MonitorElement to signal if the update was vetoed #39563

Merged
merged 1 commit into from Oct 2, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 1, 2022

backport of #39552

PR description:

In PR #28318 some additional details plots were added to the SiPixelAli PCL in order to display more information about if and why the upload was vetoed.
On the other hand the current setup is not super-clear to read if one just wants to know if there was a veto or not.
For this reason we decided to add a simple string MonitorElement in order to write if the DB was updated, there was a veto or N/A in case the PCL was not run.

PR validation:

cmssw compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #39552 (for data-taking purposes)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 1, 2022

test parameters:

  • workflows = 1001.2, 1001.3

@mmusich
Copy link
Contributor Author

mmusich commented Oct 1, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e923e/27900/summary.html
COMMIT: cd79ae8
CMSSW: CMSSW_12_4_X_2022-09-30-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39563/27900/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0e923e/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0e923e/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3692337
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692313
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.076 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 1001.2 ): 0.039 KiB AlCaReco/SiPixelAliHG
  • DQMHistoSizes: changed ( 1001.3 ): 0.037 KiB AlCaReco/SiPixelAli
  • Checked 219 log files, 45 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

+alca

  • differences only in MTD
  • backport ok

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 2, 2022

+1

@cmsbuild cmsbuild merged commit 78c4db7 into cms-sw:CMSSW_12_4_X Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants