Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_6_X] RPCDqmClient crash fix for 0 LS runs #39633

Merged
merged 1 commit into from Oct 11, 2022

Conversation

pmandrik
Copy link
Contributor

@pmandrik pmandrik commented Oct 5, 2022

PR description:

see #39630

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

@pmandrik, CMSSW_12_6_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39633/32431

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

A new Pull Request was created by @pmandrik (Petr Mandrik) for master.

It involves the following packages:

  • DQM/RPCMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@acimmino this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@rappoccio
Copy link
Contributor

please test

@rappoccio
Copy link
Contributor

please abort

@rappoccio
Copy link
Contributor

Need resources for higher priority PRs

@emanueleusai
Copy link
Member

@pmandrik can you please remove "[12_6_X]" from the PR title

@emanueleusai
Copy link
Member

@rappoccio can you please let us know when it is appropriate to restart the tests for this and the other DQM PRs?

@perrotta
Copy link
Contributor

perrotta commented Oct 7, 2022

please test
(@emanueleusai thank you for asking: we can do it even now: the outage was yesterday)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40bc1e/28090/summary.html
COMMIT: ac555f0
CMSSW: CMSSW_12_6_X_2022-10-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39633/28090/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-40bc1e/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3391103
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6238150 into cms-sw:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants