Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary deprecated header from VertexProducer.cc #39638

Merged
merged 1 commit into from Oct 6, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This is part of a cleanup campaign for FWCore/Framework/interface/EDProducer.h.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39638/32437

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • L1Trigger/VertexFinder (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@perrotta
Copy link
Contributor

perrotta commented Oct 6, 2022

please abort

@perrotta
Copy link
Contributor

perrotta commented Oct 6, 2022

merge
(removing an unused and deprecated header does not require any test)

@cmsbuild cmsbuild merged commit d4d5366 into cms-sw:master Oct 6, 2022
@Dr15Jones Dr15Jones deleted the headerL1TriggerVertexFinder branch October 6, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants