Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_4_X (9/N) [12_6_X] #39677

Merged
merged 1 commit into from Oct 8, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Oct 8, 2022

PR description:

Development of HLT menus for CMSSW_12_4_X.

This is the PR for the master branch, which will then be backported to 12_5_X and 12_4_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2471: [HIon] update of triggers for ultra-peripheral collisions (HIForward PD, still placeholders for L1T seeds)
  • CMSHLT-2474: [TSG] fixes to PS values of 5 triggers (e.g. HLT_ZeroBias_Alignment_v*)
  • CMSHLT-2486: [BPH] new triggers with dz requirement for double-electron parking
  • CMSHLT-2487: [BPH] single-electron control trigger for double-electron parking triggers (currectly disabled, PS=0)
  • CMSHLT-2488: [BPH] another single-electron control trigger for double-electron parking triggers (currectly disabled, PS=0)
  • CMSHLT-2494: [EXO] fix to inclusive delayed-jet control trigger

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_4_X
CMSSW_12_5_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39677/32488

  • This PR adds an extra 904KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Oct 8, 2022

enable gpu

@missirol
Copy link
Contributor Author

missirol commented Oct 8, 2022

please test

@missirol
Copy link
Contributor Author

missirol commented Oct 8, 2022

please abort

All 3 GPU wfs failed with the following error:

----- Begin Fatal Exception 08-Oct-2022 08:11:31 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing service of type CUDAService
Exception Message:
A std::exception was thrown.

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c1203ad0f844b94e556a08cd3c870f28/opt/cmssw/el8_amd64_gcc10/cms/cmssw/CMSSW_12_6_X_2022-10-04-2300/src/HeterogeneousCore/CUDAServices/src/CUDAService.cc, line 151:
nvmlCheck(nvmlInitWithFlags(NVML_INIT_FLAG_NO_GPUS | NVML_INIT_FLAG_NO_ATTACH));
NVML Error 18: Driver/library version mismatch
----- End Fatal Exception -------------------------------------------------

I'll try to restart the tests, in case it is a transient issue (I'd say it is clearly unrelated to this PR).

@missirol
Copy link
Contributor Author

missirol commented Oct 8, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8a6c5/28122/summary.html
COMMIT: 6d15f75
CMSSW: CMSSW_12_6_X_2022-10-07-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39677/28122/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a8a6c5/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3391097
  • DQMHistoTests: Total failures: 1211
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3389858
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 284.16 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 24.847 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): 22.514 KiB HLT/Filters
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 48 workflows

GPU Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.506 step 2
11634.512 step 2
11634.522 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 45 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 6 log files, 3 edm output root files, 1 DQM output files

@missirol
Copy link
Contributor Author

missirol commented Oct 8, 2022

+hlt

  • differences in the outputs of PR tests are in line with updates to the HLT GRun menu

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 8, 2022

+1

@cmsbuild cmsbuild merged commit f7d5a0d into cms-sw:master Oct 8, 2022
@missirol missirol deleted the HLTdevelopment124X_for126X branch October 12, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants