[12.4.X] Fix number of aligned modules for HG PCL Tracker alignment

[dmeuser]

Backport of #39707

PR description:

With this PR an inconsistency in the derivation of the number of aligned modules is fixed. The number of aligned modules is required in the new thresholds logic used for the HG PCL alignment. Without the fix only modules, without entries in the binary files, were counted as non-aligned. Now also modules, which do not fulfill the N_hits requirement of MillePede, are counted as non-aligned.

PR validation:

The PR was validated by rerunning the HG PCL alignment for one recent run (360130) using the following two commands:

cmsDriver.py step3 -s ALCA:PromptCalibProdSiPixelAliHG --conditions 124X_dataRun3_Express_v5 --datatier ALCARECO --eventcontent ALCARECO --triggerResultsProcess RECO --dasquery="file dataset=/StreamExpress/Run2022E-TkAlMinBias-Express-v1/ALCARECO run=360130" --processName=ReALCA -n -1

cmsDriver.py step7 -s ALCAHARVEST:SiPixelAliHG --conditions 124X_dataRun3_Express_v5 --scenario pp --data --filein file:PromptCalibProdSiPixelAliHG.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39707 which is needed for the HG PCL alignment running on Tier-0.

@mmusich, @connorpa, @antoniovagnerini, @consuegs

[cmsbuild]

A new Pull Request was created by @dmeuser for CMSSW_12_4_X.

It involves the following packages:

• Alignment/MillePedeAlignmentAlgorithm (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix number of aligned modules for HG PCL Tracker alignment #39707

[mmusich]

test parameters:

• workflows = 1001.2, 1001.3

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f2ed3/28196/summary.html
COMMIT: 7e6eae4
CMSSW: CMSSW_12_4_X_2022-10-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39708/28196/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8f2ed3/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8f2ed3/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3690099
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3690063
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 51 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 219 log files, 45 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[mmusich]

type trk, bug-fix

[ChrisMisan]

+alca

• PR changes match the description
• differences in msgLogger and MTD are unrelated to this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

Will wait for IBs to complete for the 12_6 branch #39707 and then merge this one.

[perrotta]

+1