Add option to cut H<a+bE+cE*E

[bennettgberg]

PR description:

Adds an option to change the H/E cut to take the form H<a+bE+cE^2 for constants a, b, c.
This will be needed for Egamma objects in upcoming changes to the Scouting trigger.
Default behavior stays unchanged.

• No changes in output
• No external dependencies
• slides presented to TSG on the change in Scouting: https://indico.cern.ch/event/1186562/contributions/4992593/attachments/2489115/4274414/electronScouting_22-08-03.pdf
  In particular, slide 10 shows the physics motivation--large increase in low-pT scouting electron signal reconstruction efficiency resulting from changing this cut.

PR validation:

Tested with scram b code-checks and scram b code-format. Further tests performed locally showing expected behavior of the code changes--namely, when doAnd is set to true with non-zero values for cut and cutOverE specified, all resulting scouting electrons in the collection obey H < cutOverE*E + cut and the number of these electrons is reasonable.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39762/32624

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39762/32624/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39762/32624/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39762/32625

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @bennettgberg for master.

It involves the following packages:

• RecoEgamma/EgammaHLTProducers (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Sam-Harper, @HuguesBrun, @silviodonato, @jainshilpi, @sameasy, @valsdav, @Fedespring, @lgray, @missirol, @sobhatta, @afiqaize, @wrtabb, @Prasant1993, @varuns23, @cericeci, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93e654/28351/summary.html
COMMIT: 4d38dbb
CMSSW: CMSSW_12_6_X_2022-10-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39762/28351/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391130
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

This will be needed for Egamma objects in upcoming changes to the Scouting trigger.

@bennettgberg , what is the ETA of this update to the HLT menu (cc: @silviodonato)? If it is for 2022 data-taking, this PR will need to be backported to 12_5_X and 12_4_X.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[bennettgberg]

+hlt

This will be needed for Egamma objects in upcoming changes to the Scouting trigger.

@bennettgberg , what is the ETA of this update to the HLT menu (cc: @silviodonato)? If it is for 2022 data-taking, this PR will need to be backported to 12_5_X and 12_4_X.

It should be in full operation for 2023 data taking, but we may want to test at the end of 2022 so I will make the backport PR. Thank you!

[perrotta]

+1