Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and cleaning of BPH trigger DQM/RelVal plots #39768

Merged
merged 3 commits into from Oct 21, 2022

Conversation

vjmastra
Copy link
Contributor

PR description:

Update DQM and RelVal code for BPH Trigger plots to take into account new triggers (eg inclusive dimuon trigger HLT_DoubleMuon4_3_LowMass_v), few changes in path names and cleaning of empty plots

Short report in STEAM meeting: https://indico.cern.ch/event/1180797/#17-b-physics-quarkonia-pag

PR validation:

Code has been tested following twiki in CMSSW 12_6_0_pre3 on a BuMixing RelVal file

Output file: /afs/cern.ch/user/v/vmastrap/public/bph-dqm-12_6_0_pre3/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This should be backported to 12_4_X for the data taking (if possible)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39768/32632

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vjmastra (Vincenzo) for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • HLTriggerOffline/HeavyFlavor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf61e2/28387/summary.html
COMMIT: 6cb6fd2
CMSSW: CMSSW_12_6_X_2022-10-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39768/28387/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3374862
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3374831
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -30771.018 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -5128.503 KiB HLT/BPH
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants