Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eta cut to HLT Egamma objects - BackportFrom126X to 124X #39791

Merged

Conversation

arsahasransu
Copy link
Contributor

@arsahasransu arsahasransu commented Oct 20, 2022

PR description:

  • Added a module to do eta filtering of HLT Egamma objects
  • Necessary for an eta cut on objects in the trigger HLT_DiPhoton10Time1p2ns_v

PR validation:

  • Checked the functionality of the filter module and verified that the eta cuts function as intended. A basic plot is shown below.
  • The red histogram is after the eta cut while the blue histogram is before cut. An |eta|<2.15 has been applied as can be observed by comparing the plots.
  • Code checks and code format performed
  • Based on advice from @Martin-Grunewald on a similar PR at Added a module to do eta filtering for Egamma HLT candidates #39764, it was decided to change the HLTEgammaEtFilter class in place of adding a new class.

PR backport:

Screenshot from 2022-10-19 09-12-41

Will squash soon.

Co-authored-by: Marino Missiroli <m.missiroli@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2022

A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for CMSSW_12_4_X.

It involves the following packages:

  • HLTrigger/Egamma (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@arsahasransu
Copy link
Contributor Author

backport of #39789

@missirol
Copy link
Contributor

backport of #39789

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f3a59/28400/summary.html
COMMIT: 00d79e3
CMSSW: CMSSW_12_4_X_2022-10-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39791/28400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675164
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3675134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 42edbeb into cms-sw:CMSSW_12_4_X Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants