Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cms::alpakatools::host() non-static [12.5.x] #39814

Merged
merged 1 commit into from Oct 22, 2022

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 21, 2022

PR description:

Make cms::alpakatools::host() non-static to prevent generating multiple instances of the same function-static variables.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39813 to 12.5.x to ease the Alpaka migration

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 21, 2022

type bugfix

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Oct 21, 2022
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 21, 2022

backport #39813

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 21, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_5_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 21, 2022

please test

@fwyzard fwyzard changed the title Make cms::alpakatools::host() non static Make cms::alpakatools::host() non-static [12.5.x] Oct 21, 2022
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1c64e/28423/summary.html
COMMIT: 42d3bdf
CMSSW: CMSSW_12_5_X_2022-10-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39814/28423/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3697216
  • DQMHistoTests: Total failures: 998
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696196
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 21, 2022

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 21, 2022

please test

To see if the input relvals pass...

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1c64e/28432/summary.html
COMMIT: 42d3bdf
CMSSW: CMSSW_12_5_X_2022-10-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39814/28432/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3697216
  • DQMHistoTests: Total failures: 1098
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696096
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a6a6ac5 into cms-sw:CMSSW_12_5_X Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants