Phase2 hgcx3

[bsunanda]

Needed for HGCal

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase2 hgcx3

It involves the following packages:

Geometry/CaloEventSetup
Geometry/CaloTopology
Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ianna]

@bsunanda - I think, you meant const reference here:

const HGCalDDDConstants&

[bsunanda]

Hi Yana

You are right - I just pushed this change in the same branch. Could you
check if this is in or should I make a new push and pull request?

Sunanda

On Fri, 23 May 2014, ianna wrote:

In Geometry/CaloEventSetup/plugins/HGCalTopologyBuilder.cc:

@@ -90,7 +90,7 @@ HGCalTopologyBuilder::produce(const IdealGeometryRecord&
iRecord ) {

edm::ESHandle pHGDC;
iRecord.get(name_, pHGDC) ;

• const HGCalDDDConstants* hgdc = &(*pHGDC);
• const HGCalDDDConstants hgdc = (*pHGDC);

@bsunanda - I think, you meant const reference here:

const HGCalDDDConstants&

—
Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNjQ2Nj
QxNywiZGF0YSI6eyJpZCI6MzI5NDgwNDR9fQ==--604acc6108f8ecf420414f99e02bf26c246
4dc9e.gif]

[mark-grimes]

This is fine, I've already tested it before the change to a reference. The only difference should be that there is no longer a copy so I'll just merge.

[mark-grimes]

merge

Tested on top of other pull requests. Notes are on #3982. Note that this test was before the change to a reference, but this should have no effect on the results so I won't test again.

[cmsbuild]

Pull request #3983 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again.