Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] use ibeos protocol for DQM/Integration unit tests (online DQM unit tests) #39830

Merged
merged 1 commit into from Oct 24, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 23, 2022

backport of #39829

PR description:

Title says it all, from suggestion at #39669 (comment)

PR validation:

Run successfully scram b runtests use-ibeos with the fix

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #39829 to CMSSW_12_4_X

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Oct 23, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Oct 23, 2022

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Oct 23, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich changed the title [12.5.X] use ibeos protocol for DQM/Integration unit tests (online DQM unit tests) [12.4.X] use ibeos protocol for DQM/Integration unit tests (online DQM unit tests) Oct 23, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b638b7/28448/summary.html
COMMIT: 01e1e27
CMSSW: CMSSW_12_4_X_2022-10-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39830/28448/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675164
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3675134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 24, 2022

urgent

  • please @cms-sw/dqm-l2 have a look (IBs are still broken)

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bf68277 into cms-sw:CMSSW_12_4_X Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants