New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated JetPartonCorrector #39848
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39848/32728
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages:
@cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36de9d/28502/summary.html Comparison SummarySummary:
|
@wddgit , you still have a |
e761f15
to
f11c106
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39848/32762
|
please test I force pushed a revised commit that also removes BuildFile.xml. @smuzaffar, thanks. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39848/32764
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
please test I don't see how this could fail? Maybe a temporary glitch? Try again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36de9d/28544/summary.html Comparison SummarySummary:
|
+1 |
merge |
PR description:
Remove dead code not referenced or used by anything. It hasn't been under development for many years. This is motivated by the ::JetCorrector migration. This code inherits from the deprecated ::JetCorrector class. We are migrating away from that class with the intent to delete it entirely soon.
@smuzaffar This package will be basically empty after this PR is merged. I don't know how to delete a package or if it is worth the effort, but this package could be deleted entirely.
PR validation:
None needed. Just deletions.